Matthias Clasen [Mon, 17 Jun 2019 02:46:48 +0000 (22:46 -0400)]
popover: Drop unused api
The inspector is no longer using this
list model, so drop the api.
Matthias Clasen [Mon, 17 Jun 2019 02:45:17 +0000 (22:45 -0400)]
inspector: Don't duplicate popovers
Popovers are now regular children in the widget
tree, no need to duplicate them as toplevels
in the object tree.
Matthias Clasen [Mon, 17 Jun 2019 02:10:33 +0000 (02:10 +0000)]
inspector: Add a refresh button for actions
Action state updates may not always be precise.
Matthias Clasen [Mon, 17 Jun 2019 01:21:17 +0000 (21:21 -0400)]
inspector: Fix centering of subtitles
Matthias Clasen [Sun, 16 Jun 2019 01:59:58 +0000 (01:59 +0000)]
Merge branch 'matthiasc-for-master' into 'master'
Matthiasc for master
See merge request GNOME/gtk!942
Matthias Clasen [Sat, 15 Jun 2019 22:36:46 +0000 (22:36 +0000)]
Drop gtk_widget_get_action_group
Ths api exposes too much of the internal
action muxer setup; we want to add actions
to the muxer without an action group.
Matthias Clasen [Sat, 15 Jun 2019 22:25:05 +0000 (22:25 +0000)]
places sidebar: Stop using gtk_widget_get_action_group
We create this action group ourselves,
we can keep track of it.
Matthias Clasen [Sat, 15 Jun 2019 22:24:26 +0000 (22:24 +0000)]
file chooser: Stop using gtk_widget_get_action_group
We create this action group ourselves,
we can keep track of it.
Matthias Clasen [Fri, 14 Jun 2019 16:43:58 +0000 (16:43 +0000)]
entry: Remove hacky code
We can leave it up to apps to not set less-than-useful
combinations, such as show-emoji-icon, but a no-emoji
input hint.
Matthias Clasen [Sun, 16 Jun 2019 00:17:45 +0000 (00:17 +0000)]
widget: Remove gtk_widget_list_action_prefixes
This function was added just for the inspector,
and is not used there anymore. Drop it.
Matthias Clasen [Sat, 15 Jun 2019 22:10:33 +0000 (22:10 +0000)]
widget: Cosmetics
Matthias Clasen [Sat, 15 Jun 2019 22:05:54 +0000 (22:05 +0000)]
inspector: Fix actionable handling
Matthias Clasen [Sat, 15 Jun 2019 21:54:45 +0000 (21:54 +0000)]
inspector: Redo the action page
Instead of iterating action groups manually,
just show what the action muxer provides. This
gives an accurate view of what actions are
available in a widgets context, and saves us
the trouble of juggling prefixes manually.
Matthias Clasen [Sat, 15 Jun 2019 22:04:19 +0000 (22:04 +0000)]
action muxer: cosmetics
Matthias Clasen [Fri, 14 Jun 2019 17:41:45 +0000 (13:41 -0400)]
action muxer: Add some convenience api
Instead of duplicating this code in multiple places,
add an api to look up an action group for a prefixed
name, and return the unprefixed name at the same time.
Matthias Clasen [Sun, 16 Jun 2019 01:38:12 +0000 (01:38 +0000)]
menu tracker item: Improve logging
Pass the action name along, so we can put
it in log messages.
Matthias Clasen [Sat, 15 Jun 2019 04:51:11 +0000 (00:51 -0400)]
Remove an accidental addition
Daniel Boles [Fri, 14 Jun 2019 17:05:06 +0000 (18:05 +0100)]
testsuite/a11y/about: Fix exp. output per
31066a69
cherry-pick of commit
e56a9e6ce5acd05677ece04c85ef219555a5f8e5
Close #1949
Matthias Clasen [Thu, 13 Jun 2019 22:28:37 +0000 (22:28 +0000)]
Merge branch 'wip/chergert/profiler-event-marks-4' into 'master'
profiler: add profiler marks for surface event delivery
See merge request GNOME/gtk!934
Christian Hergert [Thu, 13 Jun 2019 19:37:16 +0000 (12:37 -0700)]
profiler: add profiler marks for surface event delivery
This gives us marks to track the duration of processing certain types of
GdkEvent. It also provides some basic struct information in cases where
having that information would likely be useful for debugging.
Matthias Clasen [Thu, 13 Jun 2019 21:11:56 +0000 (21:11 +0000)]
Merge branch 'gtkprintunixdialog-ui' into 'master'
Slightly ease page range entry in PrintUnixDialog
Closes #591
See merge request GNOME/gtk!922
Guillaume Maudoux [Thu, 13 Jun 2019 21:11:56 +0000 (21:11 +0000)]
PrintUnixDialog: Slightly ease page range entry
Page ranges entry can now be focused directly, and will automatically
select the page ranges button when doing so.
This avoids the sometimes counter-intuitive previous behavior where the
entry was automatically focused when toggling the radio button, but the
user may still find themselves clicking uselessly in the text entry
because they scheduled it in their mental model.
Balázs Meskó [Thu, 13 Jun 2019 20:13:42 +0000 (20:13 +0000)]
Update Hungarian translation
Matthias Clasen [Thu, 13 Jun 2019 19:58:07 +0000 (15:58 -0400)]
print operation: Reinstate the priv pointer
The attempt to drop it in
6a669265ac6854af0ec
was incomplete, and non-working.
Matthias Clasen [Thu, 13 Jun 2019 19:31:48 +0000 (19:31 +0000)]
headerbar: Fix fallback appmenu
We were using menubuttons here in a way that
does not work anymore. Make it work again.
Piotr Drąg [Thu, 13 Jun 2019 16:54:42 +0000 (18:54 +0200)]
Update POTFILES.in
Matthias Clasen [Thu, 13 Jun 2019 16:45:07 +0000 (16:45 +0000)]
Merge branch 'message-dialog-title' into 'master'
Message dialog title
See merge request GNOME/gtk!894
Matthias Clasen [Fri, 31 May 2019 12:10:02 +0000 (12:10 +0000)]
message dialog: Stop hardcoding title styles
Instead, use a new title style class to let
themes influence title formatting. Note that
the theme style will be overridden if the
application uses markup for presentation,
such as <b> or <i>.
Matthias Clasen [Thu, 13 Jun 2019 12:17:54 +0000 (12:17 +0000)]
Merge branch 'wip/matthiasc/context-menu' into 'master'
context menu api
See merge request GNOME/gtk!539
Matthias Clasen [Wed, 12 Jun 2019 03:02:15 +0000 (03:02 +0000)]
color chooser: Use a popover menu
Make the color chooser use a popover menu
and actions.
Matthias Clasen [Wed, 12 Jun 2019 01:34:19 +0000 (01:34 +0000)]
link button: Use new context menu api
Matthias Clasen [Thu, 11 Apr 2019 18:48:06 +0000 (14:48 -0400)]
treeview: Stop disabling the context menu
Matthias Clasen [Tue, 5 Feb 2019 08:52:38 +0000 (03:52 -0500)]
places sidebar: remove populate-popup
Matthias Clasen [Tue, 5 Feb 2019 08:52:03 +0000 (03:52 -0500)]
cell renderer: remove populate-popup
Matthias Clasen [Tue, 29 Jan 2019 00:14:36 +0000 (19:14 -0500)]
widget-factory: Redo the context menu example
Redo the context menu on the page1 text view in
terms of actions.
Matthias Clasen [Sun, 27 Jan 2019 05:57:42 +0000 (00:57 -0500)]
gtk-demo: Rewrite the search entry demo
Port this from ::populate-popup to the new context
menu api. At the same time, fix some parts of the demo
that were broken since it was changed to use GtkStearchEntry.
Matthias Clasen [Tue, 29 Jan 2019 00:56:08 +0000 (19:56 -0500)]
textview: Support toggle actions
When creating a touch selection bubble, create toggle
buttons for toggle actions.
Matthias Clasen [Mon, 28 Jan 2019 21:47:53 +0000 (16:47 -0500)]
textview: Redo context menus
Drop the ::populate-popup signal and implement
the new context menu api.
Matthias Clasen [Sun, 27 Jan 2019 21:43:54 +0000 (16:43 -0500)]
label: Redo context menus
Drop the ::populate-popup signal and implement
the new context menu api. Things are a bit more
complicated here, since we have different menus
on links and selectable text.
Matthias Clasen [Thu, 11 Apr 2019 18:46:55 +0000 (14:46 -0400)]
password entry: Adapt to new context menu api
Matthias Clasen [Thu, 11 Apr 2019 18:47:20 +0000 (14:47 -0400)]
text: Add a context action for visibility
This will be used by GtkPasswordEntry for amending
the context menu.
Matthias Clasen [Mon, 8 Apr 2019 04:27:59 +0000 (04:27 +0000)]
text, entry: Implement context menu api
Drop the ::populate-popup signal and implement
the new context menu api.
Matthias Clasen [Thu, 13 Jun 2019 00:13:21 +0000 (00:13 +0000)]
popover menu: Unify hover and focus
Menus traditionally don't have separate
hover and focus locations. Make the same
change here that we already did for
popover menubars: Track the active item
and set its selected state. Both keynav
and mouse change the active item.
Matthias Clasen [Thu, 13 Jun 2019 00:12:33 +0000 (00:12 +0000)]
popover menubar: Use a pseudo state
Use :selected instead of .active to
mark the active item.
Matthias Clasen [Thu, 13 Jun 2019 00:11:32 +0000 (00:11 +0000)]
popover: Improve the move-focus fix
Avoid breaking menubar keynav (we still
need the focus change to be propagated
down from the root).
Matthias Clasen [Wed, 12 Jun 2019 19:54:26 +0000 (19:54 +0000)]
popover menu bar: Don't leave active item behind
When the mouse leaves the bar, turn the lights off.
Matthias Clasen [Wed, 12 Jun 2019 19:07:29 +0000 (19:07 +0000)]
wayland: Fix the popover race workaround
The Wayland backend has a hack to work around
a race with popover mapping: If the surface size
changes before the initial configure, we hide and
show the surface. Unfortunately, the code was doing
this in a way that is externally observable (by
listening for surface state changes), and popovers
were observing it and hiding themselves in response.
Avoid this by not going through the GDK frontend
code for this.
Matthias Clasen [Wed, 12 Jun 2019 16:55:43 +0000 (16:55 +0000)]
popover menu: Add our own activate key bindings
This solves issues with parent widgets, like combobox
or entry, installing their own bindings for these
keys, overriding the activation behavior that
is implemented in gtkwindow.
Matthias Clasen [Wed, 12 Jun 2019 16:54:57 +0000 (16:54 +0000)]
popover: Bring back the activate-default signal
As long as key bindings only work via action
signals, we need a signal here in order to
override the Enter/Space bindings for popover
menus.
Matthias Clasen [Wed, 12 Jun 2019 16:35:36 +0000 (16:35 +0000)]
popover menu: Add our own focus key bindings
This solves issues with parent widgets, like textview
or scrolled window or combobox installing their own
bindings for these keys, overriding the focus behavior
that is implemented in gtkwindow.
Matthias Clasen [Wed, 12 Jun 2019 00:56:40 +0000 (00:56 +0000)]
color editor: Don't leak adjustments
Matthias Clasen [Wed, 12 Jun 2019 00:57:01 +0000 (00:57 +0000)]
color editor: Fix numerical oddities
This is probably ue to a pass through gtk-builder-tool.
Matthias Clasen [Wed, 12 Jun 2019 16:18:36 +0000 (16:18 +0000)]
Merge branch 'wip/dboles/scrolledwindow-annotations' into 'master'
ScrolledWindow: Replace deprecated annotations; add (nullable) to set_[hvadjustment]()
See merge request GNOME/gtk!868
Emmanuele Bassi [Wed, 12 Jun 2019 11:18:05 +0000 (11:18 +0000)]
Merge branch 'layout-avoid-native' into 'master'
layout managers: Handle native children
See merge request GNOME/gtk!926
Jakub Steiner [Fri, 7 Jun 2019 08:46:42 +0000 (10:46 +0200)]
Adwaita: update treeview progressbars
- The style resembles Clearlooks and is way outdated.
https://gitlab.gnome.org/GNOME/gtk/issues/1938
Matthias Clasen [Wed, 12 Jun 2019 01:04:53 +0000 (01:04 +0000)]
Merge branch 'wip/chergert/profiler-gtk4-dbus-api' into 'master'
gtkapplication: track changes to profiler D-Bus API
See merge request GNOME/gtk!919
Matthias Clasen [Mon, 10 Jun 2019 18:01:59 +0000 (18:01 +0000)]
layout managers: Handle native children
Add a convenience api to skip children
that should not be included in the layout,
and call gtk_native_check_resize on all
native children outside of the vfunc.
Matthias Clasen [Mon, 10 Jun 2019 21:40:14 +0000 (21:40 +0000)]
text: Fix selection bubble handling
Same fix as the previous commit.
Matthias Clasen [Mon, 10 Jun 2019 21:39:14 +0000 (21:39 +0000)]
text view: Fix selection bubble handling
We can't call gtk_widget_destroy on something
that wasn't added as a child to a container -
it ends up calling gtk_container_remove, which
asserts if it doesn't find the child.
Matthias Clasen [Mon, 10 Jun 2019 23:33:36 +0000 (23:33 +0000)]
popover menu: Set autohide
This is the expected behavior for menus.
Matthias Clasen [Tue, 11 Jun 2019 17:36:40 +0000 (17:36 +0000)]
Merge branch 'focusable-containers' into 'master'
Focusable containers
See merge request GNOME/gtk!929
Matthias Clasen [Tue, 11 Jun 2019 17:10:16 +0000 (17:10 +0000)]
Add a focus-chain test for focusable containers
Matthias Clasen [Tue, 11 Jun 2019 17:09:10 +0000 (17:09 +0000)]
widget: Improve focus handling
Make gtk_widget_real_focus do the right
thing for focusable widgets with children.
A case where this is (now) relevant is
an entry with a context popover.
Matthias Clasen [Tue, 11 Jun 2019 15:48:07 +0000 (15:48 +0000)]
testsuite: Be robust against broken focus
When we start cycling on a subset, abort
after a while.
Matthias Clasen [Tue, 11 Jun 2019 14:53:08 +0000 (14:53 +0000)]
testsuite: more focus-chain output
Differentiate between wrapping around and
stopping at the end of the focus chain.
Update the existing tests, and add two
new ones where the difference matters.
Matthias Clasen [Tue, 11 Jun 2019 14:28:04 +0000 (14:28 +0000)]
Merge branch 'focus-chain-test' into 'master'
Focus chain test
See merge request GNOME/gtk!927
Matthias Clasen [Tue, 11 Jun 2019 14:11:28 +0000 (14:11 +0000)]
Add a focus chain test
Add a test that enumerates the focus chain by
emitting move-focus repeatedly, and compares
the result to expected output.
The test expects a ui file and a reference
file as input. The reference file can be created
using the --generate option.
Matthias Clasen [Tue, 11 Jun 2019 13:14:25 +0000 (13:14 +0000)]
window: Fix focus wraparound
If tab focus falls off the end, and we have an empty headerbar,
we end up with window->focus == NULL. Don't let that happen
Daniel Mustieles [Tue, 11 Jun 2019 10:56:08 +0000 (12:56 +0200)]
Updated Spanish translation
Yuras Shumovich [Mon, 10 Jun 2019 17:19:08 +0000 (17:19 +0000)]
Update Belarusian translation
Matthias Clasen [Mon, 10 Jun 2019 03:10:13 +0000 (03:10 +0000)]
Rename a bunch of private headers
We want to follow the convention that all
private headers have names ending in private.h
Matthias Clasen [Mon, 10 Jun 2019 02:19:53 +0000 (02:19 +0000)]
Adwaita: Make selection in menus visible
Benjamin Otte [Sun, 9 Jun 2019 21:35:15 +0000 (21:35 +0000)]
Merge branch 'for-master' into 'master'
testsuite: Make creating the output dir not racy
Closes #1942
See merge request GNOME/gtk!924
Benjamin Otte [Sun, 9 Jun 2019 19:49:44 +0000 (21:49 +0200)]
testsuite: Make creating the output dir not racy
Fixes #1942
Georges Basile Stavracas Neto [Sun, 9 Jun 2019 18:50:43 +0000 (18:50 +0000)]
Merge branch 'gbsneto/install-gtkpopovermenubar-h' into 'master'
Install gtkpopovermenubar.h
See merge request GNOME/gtk!923
Georges Basile Stavracas Neto [Sun, 9 Jun 2019 18:40:55 +0000 (15:40 -0300)]
build: Install gtkpopovermenubar.h
It is not listed in 'gtk_public_headers', so it is not
installed, and breaks anyone including gtk.h
Matthias Clasen [Sun, 9 Jun 2019 18:13:55 +0000 (18:13 +0000)]
Merge branch 'new-style-menu' into 'master'
New style menu
See merge request GNOME/gtk!916
Matthias Clasen [Sun, 9 Jun 2019 16:53:59 +0000 (16:53 +0000)]
popovermenubar: Add docs
Matthias Clasen [Sun, 9 Jun 2019 16:45:50 +0000 (16:45 +0000)]
Typo fix
Matthias Clasen [Sun, 9 Jun 2019 16:19:07 +0000 (16:19 +0000)]
Rename GtkPopoverBar to GtkPopoverMenuBar
Clarity over beauty.
Matthias Clasen [Sun, 9 Jun 2019 16:04:12 +0000 (16:04 +0000)]
popover bar: Add setters
Add setters/getters for the menu-model property.
Matthias Clasen [Sun, 9 Jun 2019 15:24:37 +0000 (15:24 +0000)]
Adwaita: Adapt to popover bar changes
Add some initial styling for popover bars
and popover menus. This needs revision.
Matthias Clasen [Sun, 9 Jun 2019 15:23:47 +0000 (15:23 +0000)]
popoverbar: Use a box layout
Its the cool way to do layout these days.
Matthias Clasen [Sun, 9 Jun 2019 14:09:20 +0000 (14:09 +0000)]
main: Warn if GDK sends us bad focus events
The new rule for focus events from the windowing
system is: We only want them for toplevels. If you
put focus on popups, we don't want to know about
it, and you still need to deliver key events to
the toplevel.
Matthias Clasen [Sun, 9 Jun 2019 14:08:18 +0000 (14:08 +0000)]
popover menu: Disappear on focus out
We try to keep focus inside by wrapping arrow keynav.
But focus can still escape. If it does, we want to
disappear, like any good menu should.
Matthias Clasen [Sun, 9 Jun 2019 14:03:40 +0000 (14:03 +0000)]
popover bar: Don't grab focus away from open menus
It makes them unhappy and disappear.
Matthias Clasen [Sun, 9 Jun 2019 04:19:40 +0000 (04:19 +0000)]
Expand focus tests
Matthias Clasen [Sun, 9 Jun 2019 02:25:12 +0000 (02:25 +0000)]
popover menu: Implement focus
We want to cycle around for up/down arrows.
Matthias Clasen [Sun, 9 Jun 2019 02:23:47 +0000 (02:23 +0000)]
popover bar: Implement focus
This is the proper way to do focus.
We want to cycle around for left/right arrows.
Matthias Clasen [Sun, 9 Jun 2019 02:21:05 +0000 (02:21 +0000)]
model button: Make left/right switch submenus
This is expected menu keynav behavior: If the
focused item has a submenu, open it on right
arrow press. And if we are in a submenu title,
make left arrow press close it.
Matthias Clasen [Sun, 9 Jun 2019 02:19:30 +0000 (02:19 +0000)]
menu button: Use proper focus api
Widgets are supposed to call gtk_widget_child_focus.
Calling internal focus_move function directly makes
us skip the childs ::focus() implementation, which
is where the magic happens.
Matthias Clasen [Sat, 8 Jun 2019 17:48:29 +0000 (17:48 +0000)]
popover bar: Add arrow keynav
Make left/right cycle the active item
among the bars children. Separate the styling
for the active item from :hover, since it is
a separate state, and only mixed up in menus
for historical reasons.
Matthias Clasen [Sat, 8 Jun 2019 15:28:22 +0000 (15:28 +0000)]
widget-factory: Move the popover bar to the ui file
Matthias Clasen [Sat, 8 Jun 2019 15:27:52 +0000 (15:27 +0000)]
popover bar: Add a model property
This makes it less annoying to use in ui files.
Matthias Clasen [Sat, 8 Jun 2019 13:46:38 +0000 (13:46 +0000)]
widget-factory: Don't use Return as accel
This is a bad idea, as it interacts badly with
general use of Return for activation.
Matthias Clasen [Sat, 8 Jun 2019 13:42:18 +0000 (13:42 +0000)]
popover bar: Break out items
These will grow enough functionality that its
worth having an object for it.
Matthias Clasen [Sat, 8 Jun 2019 13:40:59 +0000 (13:40 +0000)]
label: Fix mnemonic visibility handling
With non-widgets having children, we can no
longer assume that using gtk_container_forall
lets us walk the entire tree.
Matthias Clasen [Sat, 8 Jun 2019 13:40:37 +0000 (13:40 +0000)]
widget factory: Add mnemonics in popovers
These don't work!
Matthias Clasen [Sat, 8 Jun 2019 13:39:53 +0000 (13:39 +0000)]
gdk: Always deliver key events to toplevels
This is just a hack to see that this works.
Eventually, the backends should do the right
thing.
Matthias Clasen [Sat, 8 Jun 2019 03:23:22 +0000 (03:23 +0000)]
popover bar: towards menubar-like behavior
Make the open popover follow the pointer.